Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-3987-WIP-local-dictionary-tp102125p102446.html
akkio-97 commented on a change in pull request #3987:
URL:
https://github.com/apache/carbondata/pull/3987#discussion_r509151296##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
##########
@@ -325,6 +327,21 @@ private void fillPrimitiveType(byte[] pageData, CarbonColumnVector vector,
int intSizeInBytes = DataTypes.INT.getSizeInBytes();
int shortSizeInBytes = DataTypes.SHORT.getSizeInBytes();
int lengthStoredInBytes;
+ // check if local dictionary is enabled for complex primitve type and call
+ // fillVector eventually
+ if (!vectorInfo.vectorStack.isEmpty()) {
+ CarbonColumnVectorImpl tempVector =
+ (CarbonColumnVectorImpl) (vectorInfo.vectorStack.peek().getColumnVector());
+ if (tempVector.rawColumnChunk != null
+ && tempVector.rawColumnChunk.getLocalDictionary() != null) {
+ DimensionChunkStoreFactory.DimensionStoreType dimStoreType =
+ DimensionChunkStoreFactory.DimensionStoreType.LOCAL_DICT;
+ new VariableLengthDimensionColumnPage(pageData, new int[0], new int[0], pageSize,
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]