Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-3987-WIP-local-dictionary-tp102125p102459.html
akkio-97 commented on a change in pull request #3987:
URL:
https://github.com/apache/carbondata/pull/3987#discussion_r509158326##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/DimensionChunkReaderV3.java
##########
@@ -296,6 +297,12 @@ protected DimensionColumnPage decodeDimension(DimensionRawColumnChunk rawColumnP
}
}
BitSet nullBitSet = QueryUtil.getNullBitSet(pageMetadata.presence, this.compressor);
+ // store rawColumnChunk for local dictionary
+ if (vectorInfo != null && !vectorInfo.vectorStack.isEmpty()) {
Review comment:
done
##########
File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java
##########
@@ -81,6 +82,8 @@
private List<Integer> childElementsForEachRow;
+ public DimensionRawColumnChunk rawColumnChunk;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]