Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-marchpure-opened-a-new-pull-request-3977-CARBONDATA-4027-Fix-the-wrong-modifiedtim-tp101637p102696.html
marchpure commented on a change in pull request #3977:
URL:
https://github.com/apache/carbondata/pull/3977#discussion_r510663360##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
##########
@@ -430,9 +430,8 @@ class CarbonFileMetastore extends CarbonMetaStore {
thriftWriter.open(FileWriteOperation.OVERWRITE)
thriftWriter.write(thriftTableInfo)
thriftWriter.close()
- val modifiedTime = System.currentTimeMillis()
- FileFactory.getCarbonFile(schemaFilePath).setLastModifiedTime(modifiedTime)
- updateSchemasUpdatedTime(identifier.getCarbonTableIdentifier.getTableId, modifiedTime)
+ updateSchemasUpdatedTime(identifier.getCarbonTableIdentifier.getTableId,
+ System.currentTimeMillis())
Review comment:
the setLastModifiedTime funciton in CarbonFileMetastore.scala is related to other issue:
when delete external table, data loss may happen. I will handle this in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]