[GitHub] [carbondata] marchpure commented on a change in pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

Posted by GitBox on Nov 21, 2020; 12:30pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4017-CARBONDATA-4022-Fix-invalid-path-issue-for-tp103317p103345.html


marchpure commented on a change in pull request #4017:
URL: https://github.com/apache/carbondata/pull/4017#discussion_r528191040



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
##########
@@ -219,7 +220,13 @@ public void deserializeFields(DataInput in, String[] locations, String tablePath
     if (in.readBoolean()) {
       indexUniqueId = in.readUTF();
     }
-    setFilePath(tablePath + getPath());
+    String filePath = getPath();
+    if (filePath.startsWith(CarbonCommonConstants.FILE_SEPARATOR) ||

Review comment:
       How about use File.separator?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]