Login  Register

[GitHub] [carbondata] Karan980 commented on a change in pull request #4009: [CARBONDATA-4029] Fix Old Timestamp issue in alter add segement

Posted by GitBox on Nov 23, 2020; 5:52am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4009-CARBONDATA-4029-Fix-Old-Timestamp-issue-int-tp103264p103392.html


Karan980 commented on a change in pull request #4009:
URL: https://github.com/apache/carbondata/pull/4009#discussion_r528482794



##########
File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
##########
@@ -572,4 +574,18 @@ public ReadCommittedScope getReadCommitted(JobContext job, AbsoluteTableIdentifi
   public void setReadCommittedScope(ReadCommittedScope readCommittedScope) {
     this.readCommittedScope = readCommittedScope;
   }
+
+  public String getSegmentIdFromFilePath(String filePath) {

Review comment:
       _CarbonTablePath#getSegmentIdFromPath_ returns segmentId present in path. For eg: Fact/Part0/segment_**0**. But in this case we need segment id present in carbondata file name. So above method cannot be used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]