Login  Register

[GitHub] [carbondata] Karan980 commented on a change in pull request #4009: [CARBONDATA-4029] Fix Old Timestamp issue in alter add segement

Posted by GitBox on Nov 23, 2020; 9:16am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4009-CARBONDATA-4029-Fix-Old-Timestamp-issue-int-tp103264p103434.html


Karan980 commented on a change in pull request #4009:
URL: https://github.com/apache/carbondata/pull/4009#discussion_r528558754



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala
##########
@@ -781,6 +781,26 @@ class AddSegmentTestCase extends QueryTest with BeforeAndAfterAll {
     sql(s"drop table $tableName")
   }
 
+  test("Test add segment by carbon written by sdk having old timestamp") {
+    sql(s"drop table if exists external_primitive")
+    sql(
+      s"""
+         |create table external_primitive (id int, name string, rank smallint, salary double,
+         | active boolean, dob date, doj timestamp, city string, dept string) stored as carbondata
+         |""".stripMargin)
+    val externalSegmentPathWithOldTimestamp = storeLocation + "/" +
+      "external_segment_with_old_timestamp"
+    val externalSegmentPath = storeLocation + "/" + "external_segment"
+    FileFactory.deleteAllFilesOfDir(new File(externalSegmentPath))
+    copy(externalSegmentPathWithOldTimestamp, externalSegmentPath)

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]