Posted by
GitBox on
Nov 24, 2020; 10:24am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-jack86596-opened-a-new-pull-request-4019-CARBONDATA-4053-Fix-alter-table-rename-co-tp103472p103511.html
marchpure commented on a change in pull request #4019:
URL:
https://github.com/apache/carbondata/pull/4019#discussion_r529413543##########
File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AlterTableColumnRenameTestCase.scala
##########
@@ -98,7 +108,7 @@ class AlterTableColumnRenameTestCase extends QueryTest with BeforeAndAfterAll {
// Bucket Column
sql("DROP TABLE IF EXISTS rename_bucket")
sql("CREATE TABLE rename_bucket (ID Int, date Timestamp, country String, name String)" +
- " STORED AS carbondata TBLPROPERTIES ('BUCKET_NUMBER'='4', 'BUCKET_COLUMNS'='name')")
+ " STORED AS carbondata TBLPROPERTIES ('BUCKET_NUMBER'='4', 'BUCKET_COLUMNS'='name')")
Review comment:
please revert this change of format
##########
File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AlterTableColumnRenameTestCase.scala
##########
@@ -81,7 +91,7 @@ class AlterTableColumnRenameTestCase extends QueryTest with BeforeAndAfterAll {
// Non-Partition Column with Complex Datatype
sql("DROP TABLE IF EXISTS rename_complextype")
sql(s"create table rename_complextype(mapcol map<string,string>," +
- s" arraycol array<string>) stored as carbondata")
+ s" arraycol array<string>) stored as carbondata")
Review comment:
please revert this change of format
##########
File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/AlterTableColumnRenameTestCase.scala
##########
@@ -472,10 +483,10 @@ class AlterTableColumnRenameTestCase extends QueryTest with BeforeAndAfterAll {
def createPartitionTableAndLoad(): Unit = {
sql(
"CREATE TABLE rename_partition (empno int, empname String, designation String," +
- " doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int," +
- " deptname String," +
- " projectjoindate Timestamp, projectenddate Timestamp,attendance int," +
- " utilization int,salary int) PARTITIONED BY (projectcode int) STORED AS carbondata")
+ " doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int," +
Review comment:
please revert this change of format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]