Login  Register

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4021: [CARBONDATA-4057] Support Complex DataType when Save DataFrame with MODE.OVERWRITE

Posted by GitBox on Nov 25, 2020; 3:03am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-marchpure-opened-a-new-pull-request-4021-WIP-Support-Complex-DataType-in-DataFramee-tp103506p103550.html


ajantha-bhat commented on a change in pull request #4021:
URL: https://github.com/apache/carbondata/pull/4021#discussion_r530077716



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
##########
@@ -74,6 +74,9 @@ class CarbonDataFrameWriter(sqlContext: SQLContext, val dataFrame: DataFrame) {
       case decimal: DecimalType => s"decimal(${decimal.precision}, ${decimal.scale})"
       case BooleanType => CarbonType.BOOLEAN.getName
       case BinaryType => CarbonType.BINARY.getName
+      case ArrayType(elementType, _) => sparkType.simpleString
+      case StructType(fields) => sparkType.simpleString
+      case MapType(keyType, valueType, _) => sparkType.simpleString

Review comment:
       Long string columns (CarbonType.VARCHAR) also seems to be missing, can you test and add it also if required?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]