Posted by
GitBox on
Nov 25, 2020; 1:29pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-marchpure-opened-a-new-pull-request-4021-WIP-Support-Complex-DataType-in-DataFramee-tp103506p103583.html
marchpure commented on a change in pull request #4021:
URL:
https://github.com/apache/carbondata/pull/4021#discussion_r530373867##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
##########
@@ -74,6 +74,9 @@ class CarbonDataFrameWriter(sqlContext: SQLContext, val dataFrame: DataFrame) {
case decimal: DecimalType => s"decimal(${decimal.precision}, ${decimal.scale})"
case BooleanType => CarbonType.BOOLEAN.getName
case BinaryType => CarbonType.BINARY.getName
+ case ArrayType(elementType, _) => sparkType.simpleString
+ case StructType(fields) => sparkType.simpleString
+ case MapType(keyType, valueType, _) => sparkType.simpleString
Review comment:
There is no varchartype in spark.
https://spark.apache.org/docs/latest/sql-ref-datatypes.html
I have rework the testcase, All datatype are tested. please have a check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]