Posted by
GitBox on
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Zhangshunyu-opened-a-new-pull-request-4020-CARBONDATA-4054-Support-data-size-contrn-tp103477p103814.html
ajantha-bhat commented on a change in pull request #4020:
URL:
https://github.com/apache/carbondata/pull/4020#discussion_r532363057##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala
##########
@@ -191,6 +191,10 @@ private[sql] case class CarbonDescribeFormattedCommand(
CarbonProperties.getInstance()
.getProperty(CarbonCommonConstants.CARBON_MAJOR_COMPACTION_SIZE,
CarbonCommonConstants.DEFAULT_CARBON_MAJOR_COMPACTION_SIZE)), ""),
+ (CarbonCommonConstants.TABLE_MINOR_COMPACTION_SIZE.toUpperCase,
+ tblProps.getOrElse(CarbonCommonConstants.TABLE_MINOR_COMPACTION_SIZE,
+ CarbonProperties.getInstance()
+ .getProperty(CarbonCommonConstants.CARBON_MINOR_COMPACTION_SIZE, "0")), ""),
Review comment:
ok, lets keep min configurable to 1 MB and if the user not configured, we can keep -1. because 0 means, as per property skip all the segments that are greater than 0 MB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]