Posted by
GitBox on
Nov 30, 2020; 1:46pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-shenjiayu17-opened-a-new-pull-request-4012-CARBONDATA-4051-Geo-spatial-index-algort-tp103286p103871.html
VenuReddy2103 commented on a change in pull request #4012:
URL:
https://github.com/apache/carbondata/pull/4012#discussion_r532607226##########
File path: geo/src/main/java/org/apache/carbondata/geo/GeoConstants.java
##########
@@ -26,4 +26,34 @@ private GeoConstants() {
// GeoHash type Spatial Index
public static final String GEOHASH = "geohash";
+
+ // Regular expression to parse input polygons for IN_POLYGON_LIST
+ public static final String POLYGON_REG_EXPRESSION = "(?<=POLYGON \\(\\()(.*?)(?=(\\)\\)))";
Review comment:
1. why 2 `((` and `))` for each POLYGON ((x1 y1, x2 y2, x3 y3, x1 y1)) ?
2. Forcing user to give a space after POLYGON keyword. Otherwise match will not be successful. Shall we ignore these space restriction?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]