Posted by
GitBox on
Nov 30, 2020; 2:30pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-shenjiayu17-opened-a-new-pull-request-4012-CARBONDATA-4051-Geo-spatial-index-algort-tp103286p103877.html
VenuReddy2103 commented on a change in pull request #4012:
URL:
https://github.com/apache/carbondata/pull/4012#discussion_r532637439##########
File path: geo/src/main/java/org/apache/carbondata/geo/scan/filter/executor/PolygonFilterExecutorImpl.java
##########
@@ -73,8 +77,24 @@ private int getNearestRangeIndex(List<Long[]> ranges, long searchForNumber) {
* @return True or False True if current block or blocket needs to be scanned. Otherwise False.
*/
private boolean isScanRequired(byte[] maxValue, byte[] minValue) {
- PolygonExpression polygon = (PolygonExpression) exp;
- List<Long[]> ranges = polygon.getRanges();
+ List<Long[]> ranges = new ArrayList<>();
+ if (exp instanceof PolygonExpression) {
Review comment:
These changes wouldn't be required if all new expressions had extended `PolygonExpression`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]