Posted by
GitBox on
Dec 01, 2020; 1:33pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-nihal0107-opened-a-new-pull-request-4015-Handled-insert-overwrite-scenario-for-SI-tp103311p103940.html
nihal0107 commented on a change in pull request #4015:
URL:
https://github.com/apache/carbondata/pull/4015#discussion_r533408885##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala
##########
@@ -371,11 +377,12 @@ object SecondaryIndexCreator {
val loadMetadataDetails = SegmentStatusManager
.readLoadMetadata(indexCarbonTable.getMetadataPath)
- .filter(loadMetadataDetail => successSISegments.contains(loadMetadataDetail.getLoadName))
+ val loadMetadataDetail = loadMetadataDetails
Review comment:
removed as logic changed
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala
##########
@@ -385,7 +392,26 @@ object SecondaryIndexCreator {
val rebuiltSegments = SecondaryIndexUtil
.mergeDataFilesSISegments(secondaryIndexModel.segmentIdToLoadStartTimeMapping,
indexCarbonTable,
- loadMetadataDetails.toList.asJava, carbonLoadModelForMergeDataFiles)(sc)
+ loadMetadataDetail.toList.asJava, carbonLoadModelForMergeDataFiles)(sc)
+ if (isInsertOverwrite) {
+ var segmentList = new ListBuffer[String]()
+ for (loadMetadata <- loadMetadataDetails) {
Review comment:
done
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala
##########
@@ -385,7 +392,26 @@ object SecondaryIndexCreator {
val rebuiltSegments = SecondaryIndexUtil
.mergeDataFilesSISegments(secondaryIndexModel.segmentIdToLoadStartTimeMapping,
indexCarbonTable,
- loadMetadataDetails.toList.asJava, carbonLoadModelForMergeDataFiles)(sc)
+ loadMetadataDetail.toList.asJava, carbonLoadModelForMergeDataFiles)(sc)
+ if (isInsertOverwrite) {
+ var segmentList = new ListBuffer[String]()
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]