Posted by
GitBox on
Dec 03, 2020; 6:30am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-QiangCai-opened-a-new-pull-request-4013-WIP-Remove-automatically-clean-data-tp103289p104124.html
ajantha-bhat commented on a change in pull request #4013:
URL:
https://github.com/apache/carbondata/pull/4013#discussion_r534730624##########
File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java
##########
@@ -146,8 +146,8 @@ public static void cleanStaleSegmentsForPartitionTable(CarbonTable carbonTable)
* in the metadata folder and is not present in the table status file is considered as a
* stale segment. Only comparing from tablestatus file, not checking tablestatus.history file
*/
- private static void getStaleSegmentFiles(CarbonTable carbonTable, List<String> staleSegmentFiles,
- List<String> redundantSegmentFile) {
+ private static void collectStaleSegmentFiles(CarbonTable carbonTable,
Review comment:
I suggest `getStaleSegmentFiles` is fine, but make a list inside the function and send as a return value. Passing as an argument makes sense only when the list has some pre-entries or used in recursion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]