Posted by
GitBox on
Dec 03, 2020; 10:06am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-vikramahuja1001-opened-a-new-pull-request-4035-WIP-CleanFiles-Behaviour-Change-tp104048p104164.html
ajantha-bhat commented on a change in pull request #4035:
URL:
https://github.com/apache/carbondata/pull/4035#discussion_r535043361##########
File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##########
@@ -1039,17 +1039,19 @@ private static void writeLoadMetadata(AbsoluteTableIdentifier identifier,
}
}
- private static ReturnTuple isUpdateRequired(boolean isForceDeletion, CarbonTable carbonTable,
- AbsoluteTableIdentifier absoluteTableIdentifier, LoadMetadataDetails[] details) {
+ private static ReturnTuple isUpdateRequired(boolean cleanStaleInProgress, boolean
+ cleanCompactedAndMFD, CarbonTable carbonTable, AbsoluteTableIdentifier
+ absoluteTableIdentifier, LoadMetadataDetails[] details) {
// Delete marked loads
boolean isUpdateRequired = DeleteLoadFolders
- .deleteLoadFoldersFromFileSystem(absoluteTableIdentifier, isForceDeletion, details,
- carbonTable.getMetadataPath());
+ .deleteLoadFoldersFromFileSystem(absoluteTableIdentifier, cleanStaleInProgress,
+ cleanCompactedAndMFD, details, carbonTable.getMetadataPath());
Review comment:
clean `cleanCompactedAndMFD` flag is no need as everytime we need to clean it, after you fix your point 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]