Posted by
GitBox on
Dec 03, 2020; 3:30pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-QiangCai-opened-a-new-pull-request-4013-WIP-Remove-automatically-clean-data-tp103289p104203.html
akashrn5 commented on a change in pull request #4013:
URL:
https://github.com/apache/carbondata/pull/4013#discussion_r535332892##########
File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java
##########
@@ -482,176 +482,6 @@ public boolean accept(CarbonFile file) {
}
- /**
- * Handling of the clean up of old carbondata files, index files , delete delta,
- * update status files.
- * @param table clean up will be handled on this table.
- * @param forceDelete if true then max query execution timeout will not be considered.
- */
- public static void cleanUpDeltaFiles(CarbonTable table, boolean forceDelete) throws IOException {
Review comment:
cleanStaleDeltaFiles will be called only in case of exception here, please see below points
1. in Projectfordeletecommand, its called two times both in exception case and finally block, thats wrong, it should be only in finally block
2. its called multiple times in `DeleteExecution ` class which needs to be checked and avoid it.
3. since its handled only in case of exception case, how its taken care in case of application crash or shutdown scenario?
4. cleanStaleDeltaFiles had cases of handling the update and delete aborted case, how its handled now, as the complete method is removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]