Posted by
GitBox on
Dec 03, 2020; 3:42pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-QiangCai-opened-a-new-pull-request-4013-WIP-Remove-automatically-clean-data-tp103289p104207.html
akashrn5 commented on a change in pull request #4013:
URL:
https://github.com/apache/carbondata/pull/4013#discussion_r535345986##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/DropIndexCommand.scala
##########
@@ -210,12 +210,6 @@ private[sql] case class DropIndexCommand(
logError("Table metadata unlocking is unsuccessful, index table may be in stale state")
}
}
- // in case if the the physical folders still exists for the index table
- // but the carbon and hive info for the index table is removed,
- // DROP INDEX IF EXISTS should clean up those physical directories
- if (ifExistsSet && carbonTable.isEmpty) {
Review comment:
are you saying that, even though the t2 is not an index, and i call drop index on t2, it will consider as a index and drop t2 table folder? If so, we should handle there and keep this code here. This was handled specially for SI i think in negative scenarios
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]