Posted by
GitBox on
Dec 07, 2020; 12:55pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-QiangCai-opened-a-new-pull-request-4044-CARBONDATA-4062-Refactor-clean-files-featue-tp104338p104504.html
akashrn5 commented on a change in pull request #4044:
URL:
https://github.com/apache/carbondata/pull/4044#discussion_r537484782##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala
##########
@@ -48,30 +50,59 @@ class CleanFilesPostEventListener extends OperationEventListener with Logging {
event match {
case cleanFilesPostEvent: CleanFilesPostEvent =>
LOGGER.info("Clean files post event listener called")
- val carbonTable = cleanFilesPostEvent.carbonTable
- val indexTables = CarbonIndexUtil
- .getIndexCarbonTables(carbonTable, cleanFilesPostEvent.sparkSession)
- val isForceDelete = cleanFilesPostEvent.ifForceDelete
- val inProgressSegmentsClean = cleanFilesPostEvent.cleanStaleInProgress
- indexTables.foreach { indexTable =>
- val partitions: Option[Seq[PartitionSpec]] = CarbonFilters.getPartitions(
- Seq.empty[Expression],
- cleanFilesPostEvent.sparkSession,
- indexTable)
- SegmentStatusManager.deleteLoadsAndUpdateMetadata(
- indexTable, isForceDelete, partitions.map(_.asJava).orNull, inProgressSegmentsClean,
- true)
- CarbonUpdateUtil.cleanUpDeltaFiles(indexTable, true)
- cleanUpUnwantedSegmentsOfSIAndUpdateMetadata(indexTable, carbonTable)
- }
+ cleanFilesForIndex(
Review comment:
please see if you can do along with [CARBONDATA-4074](
https://issues.apache.org/jira/browse/CARBONDATA-4074)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]