Posted by
GitBox on
Dec 10, 2020; 9:58am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-nihal0107-opened-a-new-pull-request-4042-CARBONDATA-4069-handled-set-streaming-for-tp104245p104625.html
nihal0107 commented on a change in pull request #4042:
URL:
https://github.com/apache/carbondata/pull/4042#discussion_r540031120##########
File path: integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -450,14 +451,27 @@ object AlterTableUtil {
// validate long string columns
val longStringColumns = lowerCasePropertiesMap.get("long_string_columns");
if (longStringColumns.isDefined) {
- validateLongStringColumns(longStringColumns.get, carbonTable)
+ validateLongStringColumns(longStringColumns.get, carbonTable, sparkSession)
// update schema for long string columns
updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
} else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && !set)) {
if (tblPropertiesMap.exists(prop => prop._1.equalsIgnoreCase("long_string_columns"))) {
updateSchemaForLongStringColumns(thriftTable, "")
}
}
+ // validate set for streaming table
+ val streamingOption = lowerCasePropertiesMap.get("streaming")
+ if (streamingOption.isDefined && set) {
+ if (carbonTable.isIndexTable) {
+ throw new UnsupportedOperationException("Set streaming table is " +
+ "not allowed for index table.")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]