[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add segment query.

Posted by GitBox on Dec 15, 2020; 5:09am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4048-CARBONDATA-4072-Clean-files-command-is-not-tp104556p104725.html


vikramahuja1001 commented on a change in pull request #4048:
URL: https://github.com/apache/carbondata/pull/4048#discussion_r543050640



##########
File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
##########
@@ -597,6 +599,27 @@ public static String getSegmentIdFromPath(String dataFileAbsolutePath) {
     }
   }
 
+  /**

Review comment:
       you can compute the segmentFile name from the segmentFile absolute path in the test code itself. Or you can create a CarbonFile and then get the name in the test code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]