[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

Posted by GitBox on Dec 15, 2020; 5:25am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4047-CARBONDATA-4078-Add-external-segment-as-tp104517p104728.html


Indhumathi27 commented on a change in pull request #4047:
URL: https://github.com/apache/carbondata/pull/4047#discussion_r543056033



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala
##########
@@ -47,6 +47,9 @@ class DistributedIndexJob extends AbstractIndexJob {
 
   override def execute(indexFormat: IndexInputFormat,
       configuration: Configuration): util.List[ExtendedBlocklet] = {
+    // get only carbon segments.
+    indexFormat.setValidSegments(indexFormat.getValidSegments.asScala

Review comment:
       In EmbeddedIndexJob fall back mode, i think, you have to handle




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]