[GitHub] [carbondata] Karan980 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Posted by GitBox on Dec 15, 2020; 5:48am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4046-CARBONDATA-4071-Fix-wrong-values-of-date-o-tp104510p104729.html


Karan980 commented on a change in pull request #4046:
URL: https://github.com/apache/carbondata/pull/4046#discussion_r543064324



##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java
##########
@@ -126,6 +127,47 @@ public T readNextRow() throws IOException, InterruptedException {
     return formatDateAndTimeStamp((Object []) row);
   }
 
+  public Object getFormattedData(CarbonDimension dimension, Object row, SimpleDateFormat dateFormat,

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]