[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

Posted by GitBox on Dec 15, 2020; 11:27am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4047-CARBONDATA-4078-Add-external-segment-as-tp104517p104747.html


ShreelekhyaG commented on a change in pull request #4047:
URL: https://github.com/apache/carbondata/pull/4047#discussion_r543263594



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala
##########
@@ -47,6 +47,9 @@ class DistributedIndexJob extends AbstractIndexJob {
 
   override def execute(indexFormat: IndexInputFormat,
       configuration: Configuration): util.List[ExtendedBlocklet] = {
+    // get only carbon segments.
+    indexFormat.setValidSegments(indexFormat.getValidSegments.asScala

Review comment:
       in EmbeddedIndexJob fallback mode, we have `toDistributable ` method, here `loadmetadatadetails `for segments are present and carbon segments are filtered.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]