Login  Register

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

Posted by GitBox on Dec 16, 2020; 4:58am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-nihal0107-opened-a-new-pull-request-4042-CARBONDATA-4069-handled-set-streaming-for-tp104245p104781.html


nihal0107 commented on a change in pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#discussion_r543953077



##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondaryIndex.scala
##########
@@ -434,6 +434,38 @@ class TestSIWithSecondaryIndex extends QueryTest with BeforeAndAfterAll {
     assert(df.exists(_.get(0).toString.contains("nam(e")))
   }
 
+  test("test alter table set streaming for table having SI") {
+    sql("drop table if exists maintable2")
+    sql("create table maintable2 (a string,b string,c int) STORED AS carbondata ")
+    sql("insert into maintable2 values('k','x',2)")
+    sql("create index m_indextable on table maintable2(b) AS 'carbondata'")
+    var exeption = intercept[RuntimeException] {

Review comment:
       In `AlterTableUtil` line 541 we are catching the exception and making it sys.error(). Because of this it is throwing it as `RunTimeException`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]