Posted by
GitBox on
Dec 16, 2020; 7:24am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-vikramahuja1001-opened-a-new-pull-request-4051-WIP-Only-consider-segment-files-fors-tp104620p104793.html
Indhumathi27 commented on a change in pull request #4051:
URL:
https://github.com/apache/carbondata/pull/4051#discussion_r544069025##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##########
@@ -38,26 +40,33 @@ case class CarbonCleanFilesCommand(
isInternalCleanCall: Boolean = false)
extends DataCommand {
+ val LOGGER: Logger = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+
override def processData(sparkSession: SparkSession): Seq[Row] = {
Checker.validateTableExists(databaseNameOp, tableName, sparkSession)
val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
setAuditTable(carbonTable)
- // if insert overwrite in progress, do not allow delete segment
- if (SegmentStatusManager.isOverwriteInProgressInTable(carbonTable)) {
+ // if insert overwrite in progress and table not a MV, do not allow delete segment
+ if (!carbonTable.isMV && SegmentStatusManager.isOverwriteInProgressInTable(carbonTable)) {
throw new ConcurrentOperationException(carbonTable, "insert overwrite", "clean file")
}
if (!carbonTable.getTableInfo.isTransactionalTable) {
throw new MalformedCarbonCommandException("Unsupported operation on non transactional table")
}
- val preEvent = CleanFilesPreEvent(carbonTable, sparkSession)
- val postEvent = CleanFilesPostEvent(carbonTable, sparkSession, options)
- withEvents(preEvent, postEvent) {
- DataTrashManager.cleanGarbageData(
- carbonTable,
- options.getOrElse("force", "false").toBoolean,
- options.getOrElse("stale_inprogress", "false").toBoolean,
- CarbonFilters.getPartitions(Seq.empty[Expression], sparkSession, carbonTable))
+ // only proceed if not a MV and if insert overwrite not in progress
+ if (!carbonTable.isMV && !SegmentStatusManager.isOverwriteInProgressInTable(carbonTable)) {
+ val preEvent = CleanFilesPreEvent(carbonTable, sparkSession)
+ val postEvent = CleanFilesPostEvent(carbonTable, sparkSession, options)
+ withEvents(preEvent, postEvent) {
+ DataTrashManager.cleanGarbageData(
+ carbonTable,
+ options.getOrElse("force", "false").toBoolean,
+ options.getOrElse("stale_inprogress", "false").toBoolean,
+ CarbonFilters.getPartitions(Seq.empty[Expression], sparkSession, carbonTable))
+ }
+ } else {
+ LOGGER.info(s"Can not do clean files operation for the MV: ${carbonTable.getTableName}")
Review comment:
Clean files for MV is not supported?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]