[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4046: [CARBONDATA-4071] Fix wrong values of date or timestamp child columns on reading through SDK.

Posted by GitBox on Dec 16, 2020; 1:18pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4046-CARBONDATA-4071-Fix-wrong-values-of-date-o-tp104510p104824.html


Indhumathi27 commented on a change in pull request #4046:
URL: https://github.com/apache/carbondata/pull/4046#discussion_r544281555



##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java
##########
@@ -126,6 +127,81 @@ public T readNextRow() throws IOException, InterruptedException {
     return formatDateAndTimeStamp((Object []) row);
   }
 
+  /**
+   * This method converts the date and timestamp columns into right format. Before conversion date
+   * is present as integer and timestamp is present as long. This method also flattens complex
+   * columns and format the date/timestamp child present in them.
+   *
+   * @param dimension

Review comment:
       Please define the params or else remove it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]