[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add segment query.

Posted by GitBox on Dec 16, 2020; 2:06pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4048-CARBONDATA-4072-Clean-files-command-is-not-tp104556p104830.html


Indhumathi27 commented on a change in pull request #4048:
URL: https://github.com/apache/carbondata/pull/4048#discussion_r544324058



##########
File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
##########
@@ -597,6 +599,24 @@ public static String getSegmentIdFromPath(String dataFileAbsolutePath) {
     }
   }
 
+  /**
+   * gets segment id from given absolute segment file path
+   */
+  public static String getSegmentIdFromSegmentFilePath(String segmentFilePath) {

Review comment:
       If used only in test files, can move it to TestUtil




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]