Posted by
GitBox on
Dec 17, 2020; 6:01am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-vikramahuja1001-opened-a-new-pull-request-4051-WIP-Only-consider-segment-files-fors-tp104620p104848.html
ajantha-bhat commented on a change in pull request #4051:
URL:
https://github.com/apache/carbondata/pull/4051#discussion_r544833244##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
##########
@@ -38,26 +40,33 @@ case class CarbonCleanFilesCommand(
isInternalCleanCall: Boolean = false)
extends DataCommand {
+ val LOGGER: Logger = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+
override def processData(sparkSession: SparkSession): Seq[Row] = {
Checker.validateTableExists(databaseNameOp, tableName, sparkSession)
val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
setAuditTable(carbonTable)
- // if insert overwrite in progress, do not allow delete segment
- if (SegmentStatusManager.isOverwriteInProgressInTable(carbonTable)) {
+ // if insert overwrite in progress and table not a MV, do not allow delete segment
Review comment:
```suggestion
// if insert overwrite in progress and table is not a MV, do not allow delete segment
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]