[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4055: [CARBONDATA-4087] Handled issue with huge data(exceeding 32K records) after enabling local dictionary in Presto

Posted by GitBox on Dec 17, 2020; 6:58am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4055-Handled-issue-with-huge-data-exceeding-32Ky-tp104817p104857.html


ajantha-bhat commented on a change in pull request #4055:
URL: https://github.com/apache/carbondata/pull/4055#discussion_r544854194



##########
File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/CarbonColumnVector.java
##########
@@ -116,6 +117,13 @@
 
   void setLazyPage(LazyPageLoader lazyPage);
 
+  default int getIntsSize() {
+    return CarbonV3DataFormatConstants.NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT;

Review comment:
       please remove from here and keep only in impl. because this guy is not aware about Int array




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]