Posted by
GitBox on
Dec 17, 2020; 7:19am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4048-CARBONDATA-4072-Clean-files-command-is-not-tp104556p104859.html
Karan980 commented on a change in pull request #4048:
URL:
https://github.com/apache/carbondata/pull/4048#discussion_r544862924##########
File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -1125,19 +1125,21 @@ public static void deleteSegment(String tablePath, Segment segment,
SegmentFileStore fileStore = new SegmentFileStore(tablePath, segment.getSegmentFileName());
List<String> indexOrMergeFiles = fileStore.readIndexFiles(SegmentStatus.SUCCESS, true,
FileFactory.getConfiguration());
- Map<String, List<String>> indexFilesMap = fileStore.getIndexFilesMap();
- for (Map.Entry<String, List<String>> entry : indexFilesMap.entrySet()) {
- FileFactory.deleteFile(entry.getKey());
- for (String file : entry.getValue()) {
- String[] deltaFilePaths =
- updateStatusManager.getDeleteDeltaFilePath(file, segment.getSegmentNo());
- for (String deltaFilePath : deltaFilePaths) {
- FileFactory.deleteFile(deltaFilePath);
+ if (!indexOrMergeFiles.isEmpty() && indexOrMergeFiles.get(0).startsWith(tablePath)) {
Review comment:
I have modified the check for deleting physical data and also added the testcases for this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]