Login  Register

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4055: [CARBONDATA-4087] Handled issue with huge data(exceeding 32K records) after enabling local dictionary in Presto

Posted by GitBox on Dec 17, 2020; 11:05am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4055-Handled-issue-with-huge-data-exceeding-32Ky-tp104817p104877.html


akkio-97 commented on a change in pull request #4055:
URL: https://github.com/apache/carbondata/pull/4055#discussion_r545003060



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
##########
@@ -84,6 +84,9 @@ public void fillVector(int[] invertedIndex, int[] invertedIndexReverse, byte[] d
     vector = ColumnarVectorWrapperDirectFactory
         .getDirectVectorWrapperFactory(vectorInfo, vector, invertedIndex, nullBitset,
             vectorInfo.deletedRows, false, false);
+    if (dictionaryVector.getIntsSize() < rowsNum) {

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]