[GitHub] [carbondata] ajantha-bhat commented on pull request #4058: [CARBONDATA-4084]Fixed data corruption issue after fallback of Local dictionary

Posted by GitBox on Dec 18, 2020; 12:33pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-kumarvishal09-opened-a-new-pull-request-4058-CARBONDATA-4084-Fixed-data-corruptiony-tp104951p104965.html


ajantha-bhat commented on pull request #4058:
URL: https://github.com/apache/carbondata/pull/4058#issuecomment-748061201


   LGTM.
   
   
   As the actual value is already LV, putBytes() no need to append L again, but that change is more, as many classes need to modified.
   Current change of removing L from actual value and appending L again is fine as it is (corner) fallback scenario.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]