Login  Register

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4060: [CARBONDATA-4093] Added logs for MV and method to verify if mv is in Sync during query

Posted by GitBox on Dec 21, 2020; 5:45am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Indhumathi27-opened-a-new-pull-request-4060-CARBONDATA-4093-Added-logs-for-MV-and-y-tp104977p104992.html


akashrn5 commented on a change in pull request #4060:
URL: https://github.com/apache/carbondata/pull/4060#discussion_r546519558



##########
File path: core/src/main/java/org/apache/carbondata/core/view/MVManager.java
##########
@@ -114,7 +118,16 @@ public boolean hasSchemaOnTable(CarbonTable table) throws IOException {
   public List<MVSchema> getSchemas() throws IOException {
     List<MVSchema> schemas = new ArrayList<>();
     for (String database : this.getDatabases()) {
-      schemas.addAll(this.getSchemas(database));
+      try {
+        schemas.addAll(this.getSchemas(database));
+      } catch (IOException ex) {
+        throw ex;
+      } catch (Exception ex) {
+        LOGGER.error("Exception Occurred: Skipping MV schemas from database `" + database + "`.");

Review comment:
       ```suggestion
           LOGGER.error("Exception Occurred: Skipping MV schemas from database: " + database + ".");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]