Login  Register

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4060: [CARBONDATA-4093] Added logs for MV and method to verify if mv is in Sync during query

Posted by GitBox on Dec 21, 2020; 5:51am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Indhumathi27-opened-a-new-pull-request-4060-CARBONDATA-4093-Added-logs-for-MV-and-y-tp104977p104995.html


akashrn5 commented on a change in pull request #4060:
URL: https://github.com/apache/carbondata/pull/4060#discussion_r546520998



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/view/MVManagerInSpark.scala
##########
@@ -31,10 +31,10 @@ class MVManagerInSpark(session: SparkSession) extends MVManager {
   override def getDatabases: util.List[String] = {
     CarbonThreadUtil.threadSet(CarbonCommonConstants.CARBON_ENABLE_MV, "true")
     try {
-      val databaseList = session.catalog.listDatabases()
+      val databaseList = session.sessionState.catalog.listDatabases()

Review comment:
       remove the beow for loop and just do `map ` here

##########
File path: integration/spark/src/main/scala/org/apache/carbondata/view/MVManagerInSpark.scala
##########
@@ -31,10 +31,10 @@ class MVManagerInSpark(session: SparkSession) extends MVManager {
   override def getDatabases: util.List[String] = {
     CarbonThreadUtil.threadSet(CarbonCommonConstants.CARBON_ENABLE_MV, "true")
     try {
-      val databaseList = session.catalog.listDatabases()
+      val databaseList = session.sessionState.catalog.listDatabases()

Review comment:
       remove the below for loop and just do `map ` here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]