[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4059: [CARBONDATA-4092] Fix concurrent issues in delete segment API's and MV flow

Posted by GitBox on Dec 21, 2020; 6:57am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-vikramahuja1001-opened-a-new-pull-request-4059-WIP-Fix-concurrent-issues-in-deletes-tp104954p105002.html


ajantha-bhat commented on a change in pull request #4059:
URL: https://github.com/apache/carbondata/pull/4059#discussion_r546538696



##########
File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java
##########
@@ -540,7 +540,7 @@ private void checkAndReloadSchemas(MVManager viewManager, boolean touchFile)
       }
     }
 
-    private void touchMDTFile() throws IOException {
+    private synchronized void touchMDTFile() throws IOException {

Review comment:
       checkAndReloadSchemas, better to return a flag whether it has touched MDT or not, if false then only we can call touchMDT




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]