[GitHub] [carbondata] nihal0107 commented on a change in pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

Posted by GitBox on Dec 23, 2020; 10:47am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-nihal0107-opened-a-new-pull-request-4037-WIP-Handle-Alter-long-string-for-SI-col-aI-tp104125p105097.html


nihal0107 commented on a change in pull request #4037:
URL: https://github.com/apache/carbondata/pull/4037#discussion_r547896201



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala
##########
@@ -542,100 +542,6 @@ object SecondaryIndexUtil {
     indexToFactColMapping
   }
 
-  /**
-   * Identifies all segments which can be merged for compaction type - CUSTOM.
-   *
-   * @param sparkSession
-   * @param tableName
-   * @param dbName
-   * @param customSegments
-   * @return list of LoadMetadataDetails
-   * @throws UnsupportedOperationException   if customSegments is null or empty
-   */
-  def identifySegmentsToBeMergedCustom(sparkSession: SparkSession,

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]