Login  Register

[GitHub] [carbondata] ajantha-bhat commented on pull request #4067: [CARBONDATA-4100] Fix SI segments are in inconsistent state with maintable after concurrent(Load&Compaction) operation

Posted by GitBox on Dec 29, 2020; 3:31pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Indhumathi27-opened-a-new-pull-request-4067-WIP-Fix-concurrency-Load-Compaction-isI-tp105150p105190.html


ajantha-bhat commented on pull request #4067:
URL: https://github.com/apache/carbondata/pull/4067#issuecomment-752123149


   LGTM.
   
   However `processSIRepair` (base code for this PR) can be optimized further in other PR. multiple time we are reading table status and comparing main table and SI table again again. can be done in one loop.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]