Posted by
GitBox on
Dec 30, 2020; 12:43pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-nihal0107-opened-a-new-pull-request-4068-CARBONDATA-3987-Handled-filter-and-IUD-opK-tp105205p105214.html
ajantha-bhat commented on a change in pull request #4068:
URL:
https://github.com/apache/carbondata/pull/4068#discussion_r550182177##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/PaginationCarbonReader.java
##########
@@ -174,14 +170,15 @@ private Range getBlockletIndexRange(long fromRowNumber, long toRowNumber) {
BlockletDetailInfo detailInfo =
((CarbonInputSplit) allBlockletSplits.get(i)).getDetailInfo();
int rowCountInBlocklet = detailInfo.getRowCount();
- Object[] rowsInBlocklet = new Object[rowCountInBlocklet];
+ // Object[] rowsInBlocklet = new Object[rowCountInBlocklet];
+ List<Object> rowsInBlocklet = new ArrayList<>();
Review comment:
a. why not use array itself ?
b. Don't keep commented code
c. int count = 0; This is unused now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]