Login  Register

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

Posted by GitBox on Jan 08, 2021; 2:28pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ajantha-bhat-opened-a-new-pull-request-4034-WIP-support-prestosql-333-tp104025p105333.html


ajantha-bhat commented on a change in pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#discussion_r553974119



##########
File path: integration/presto/pom.xml
##########
@@ -294,7 +294,7 @@
     <dependency>
       <groupId>io.airlift</groupId>
       <artifactId>json</artifactId>
-      <version>0.144</version>
+      <version>0.193</version>

Review comment:
       If a different maven profile needs different version, then it makes sense to add a variable, here it is not needed. Also, each is a different artifact.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]