Login  Register

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

Posted by GitBox on Jan 08, 2021; 2:56pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ajantha-bhat-opened-a-new-pull-request-4034-WIP-support-prestosql-333-tp104025p105338.html


ajantha-bhat commented on a change in pull request #4034:
URL: https://github.com/apache/carbondata/pull/4034#discussion_r553990575



##########
File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbonDataPageSinkProvider.java
##########
@@ -150,8 +148,11 @@ private ConnectorPageSink createPageSink(HiveWritableTableHandle handle, Connect
         handle.getLocationHandle(),
         locationService,
         session.getQueryId(),
-        new HivePageSinkMetadataProvider(handle.getPageSinkMetadata(),
-            memoizeMetastore(metastore, perTransactionMetastoreCacheMaximumSize)),
+        new HivePageSinkMetadataProvider(
+            handle.getPageSinkMetadata(),
+            new HiveMetastoreClosure(
+                memoizeMetastore(metastore, perTransactionMetastoreCacheMaximumSize)),
+            new HiveIdentity(session)),

Review comment:
       done

##########
File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbondataConnectorFactory.java
##########
@@ -101,127 +52,109 @@
     }
   }
 
-  public CarbondataConnectorFactory(String connectorName, ClassLoader classLoader) {
-    super(connectorName, classLoader, Optional.empty());
-    this.classLoader = requireNonNull(classLoader, "classLoader is null");
+  public CarbondataConnectorFactory(String name) {

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]