[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

Posted by GitBox on Jan 29, 2021; 12:18pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4074-WIP-tp105363p105793.html


ajantha-bhat commented on a change in pull request #4074:
URL: https://github.com/apache/carbondata/pull/4074#discussion_r566782786



##########
File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala
##########
@@ -20,14 +20,15 @@ package org.apache.carbondata.presto.integrationtest
 import java.io.{File}
 import java.util
 
+import io.prestosql.jdbc.PrestoArray

Review comment:
       I think presto db compile will fail after this. can you handle validation in the util method like `PrestoTestUtil#validateArrayOfPrimitiveTypeData`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]