Login  Register

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

Posted by GitBox on Jan 29, 2021; 6:08pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-akkio-97-opened-a-new-pull-request-4074-WIP-tp105363p105815.html


akkio-97 commented on a change in pull request #4074:
URL: https://github.com/apache/carbondata/pull/4074#discussion_r567001721



##########
File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala
##########
@@ -20,14 +20,15 @@ package org.apache.carbondata.presto.integrationtest
 import java.io.{File}
 import java.util
 
+import io.prestosql.jdbc.PrestoArray

Review comment:
       done

##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala
##########
@@ -354,6 +355,7 @@ class TestLoadDataWithDiffTimestampFormat extends QueryTest with BeforeAndAfterA
 
   test("test load, update data with setlenient session level property for daylight " +
        "saving time from different timezone") {
+    TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"))

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]