Login  Register

[GitHub] [carbondata] Karan980 commented on a change in pull request #4083: [CARBONDATA-4112] Data mismatch issue in SI.

Posted by GitBox on Feb 01, 2021; 11:44am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4083-CARBONDATA-4112-Data-mismatch-issue-in-SI-tp105749p105862.html


Karan980 commented on a change in pull request #4083:
URL: https://github.com/apache/carbondata/pull/4083#discussion_r567760931



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/util/SecondaryIndexUtil.scala
##########
@@ -678,9 +678,14 @@ object SecondaryIndexUtil {
       .collectionAccumulator[Map[String, SegmentMetaDataInfo]]
     validSegments.foreach { segment =>
       outputModel.setSegmentId(segment.getSegmentNo)
-      val dataFrame = SparkSQLUtil.createInputDataFrame(
+      // As this dataframe is created to merge the data files of SI segment. So no need to calculate
+      // positionReference column again, as it is already calculated during SI segment load from
+      // main table.

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]