Login  Register

[GitHub] [carbondata] areyouokfreejoe commented on a change in pull request #4086: [CARBONDATA-4115] Successful load and insert will return segment ID

Posted by GitBox on Feb 04, 2021; 6:55am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-areyouokfreejoe-opened-a-new-pull-request-4086-CARBONDATA-4115-Successful-load-andD-tp105825p106016.html


areyouokfreejoe commented on a change in pull request #4086:
URL: https://github.com/apache/carbondata/pull/4086#discussion_r569985309



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala
##########
@@ -276,7 +280,15 @@ case class CarbonInsertIntoCommand(databaseNameOp: Option[String],
         }
         throw ex
     }
-    Seq.empty
+    if(loadResultForReturn!=null && loadResultForReturn.getLoadName!=null) {
+      Seq(Row(loadResultForReturn.getLoadName))
+    } else {
+      rowsForReturn

Review comment:
       It's not number of rows.
   It's segment id  from partition table case.
   Ok, Comment has been added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]