Login  Register

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

Posted by GitBox on Feb 05, 2021; 9:56am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Indhumathi27-opened-a-new-pull-request-4076-WIP-Added-mvExists-property-in-MV-facte-tp105379p106064.html


akashrn5 commented on a change in pull request #4076:
URL: https://github.com/apache/carbondata/pull/4076#discussion_r569996310



##########
File path: docs/mv-guide.md
##########
@@ -1,3 +1,4 @@
+

Review comment:
       remove this empty line change

##########
File path: docs/mv-guide.md
##########
@@ -241,6 +242,11 @@ The current information includes:
  | Refresh Mode          | FULL / INCREMENTAL refresh to MV                          |
  | Refresh Trigger Mode  | ON_COMMIT / ON_MANUAL refresh to MV provided by user |
  | Properties              | Table properties of the materialized view                       |
+
+**NOTE**: For materialized views created
+before [CARBONDATA-4107](https://issues.apache.org/jira/browse/CARBONDATA-4107) issue fix, run
+refresh mv command to add mv name to fact table property and to enable it. If refresh command

Review comment:
       ```suggestion
   refresh mv command to add mv name to fact table's table properties and to enable it. If refresh command
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]