Login  Register

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4090: [CARBONDATA-4122] Support HDFS Carbon writer for Flink Carbon Streaming

Posted by GitBox on Feb 09, 2021; 2:55pm
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Indhumathi27-opened-a-new-pull-request-4090-WIP-Use-CarbonFile-API-instead-of-javaa-tp106087p106111.html


ajantha-bhat commented on a change in pull request #4090:
URL: https://github.com/apache/carbondata/pull/4090#discussion_r572953288



##########
File path: docs/flink-integration-guide.md
##########
@@ -78,7 +78,7 @@ limitations under the License.
     val carbonProperties = new Properties
     // Set the carbon properties here, such as date format, store location, etc.
     
-    // Create carbon bulk writer factory. Two writer types are supported: 'Local' and 'S3'.
+    // Create carbon bulk writer factory. Three writer types are supported: 'Local', Hdfs' and 'S3'.

Review comment:
       Everywhere if we use file factory API and support HDFS conf input, only one writer is enough right ? do we need 3 writers ?
   Because in carbon table or SDK we don't create multiple type of writers to handle this kind of scenario.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]