Posted by
GitBox on
Feb 15, 2021; 10:38am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Indhumathi27-opened-a-new-pull-request-4087-WIP-SI-compatability-issue-fix-tp105998p106197.html
akashrn5 commented on a change in pull request #4087:
URL:
https://github.com/apache/carbondata/pull/4087#discussion_r576095548##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/command/SICreationCommand.scala
##########
@@ -239,6 +248,24 @@ private[sql] case class CarbonCreateSecondaryIndexCommand(
throw new ErrorMessage(
s"Table [$tableName] under database [$databaseName] is already an index table")
}
+ val absoluteTableIdentifier = AbsoluteTableIdentifier.
+ from(tablePath, databaseName, indexTableName)
+ val indexTablePath = CarbonTablePath
+ .getMetadataPath(absoluteTableIdentifier.getTablePath)
+ val mainTblLoadMetadataDetails: Array[LoadMetadataDetails] =
+ SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+ var siTblLoadMetadataDetails: Array[LoadMetadataDetails] =
+ SegmentStatusManager.readLoadMetadata(indexTablePath)
+ if (isRegisterIndex) {
+ // check if SI table has undergone any Update or delete operation, which can happen in
+ // case of compatibility scenario. IUD after Refresh SI and before register index
+ val updatedSegmentsCount = siTblLoadMetadataDetails.filter(loadMetaDetail =>
+ !loadMetaDetail.getUpdateStatusFileName.equals(""))
+ if (!updatedSegmentsCount.isEmpty) {
+ throw new ErrorMessage("Cannot Register Secondary index table " + indexTableName +
+ ", as it has undergone update or delete operation.")
Review comment:
in this scenario, if user cant register index then he needs to drop and recreated the SI right, if so, please include that in error message also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]