Posted by
GitBox on
Feb 17, 2021; 6:03am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-Karan980-opened-a-new-pull-request-4093-CARBONDATA-4126-Concurrent-compaction-fail-tp106137p106234.html
Karan980 commented on a change in pull request #4093:
URL:
https://github.com/apache/carbondata/pull/4093#discussion_r577346993##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
##########
@@ -92,19 +92,22 @@ class CarbonTableCompactor(
val lastSegment = sortedSegments.get(sortedSegments.size() - 1)
val compactedLoad = CarbonDataMergerUtil.getMergedLoadName(loadsToMerge)
var segmentLocks: ListBuffer[ICarbonLock] = ListBuffer.empty
+ val validSegments = new java.util.ArrayList[LoadMetadataDetails]
loadsToMerge.asScala.foreach { segmentId =>
val segmentLock = CarbonLockFactory
.getCarbonLockObj(carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
.getAbsoluteTableIdentifier,
CarbonTablePath.addSegmentPrefix(segmentId.getLoadName) + LockUsage.LOCK)
- if (!segmentLock.lockWithRetries()) {
- throw new Exception(s"Failed to acquire lock on segment ${segmentId.getLoadName}," +
- s" during compaction of table ${compactionModel.carbonTable.getQualifiedName}")
+ if (segmentLock.lockWithRetries()) {
+ validSegments.add(segmentId)
+ segmentLocks += segmentLock
+ } else {
+ LOGGER.warn(s"Failed to acquire lock on segment ${segmentId.getLoadName}, " +
+ s"during compaction of table ${compactionModel.carbonTable.getQualifiedName}")
}
- segmentLocks += segmentLock
}
try {
- scanSegmentsAndSubmitJob(loadsToMerge, compactedSegments, compactedLoad)
+ scanSegmentsAndSubmitJob(validSegments, compactedSegments, compactedLoad)
Review comment:
Log statement is already present inside scanSegmentAndSubmitJob api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]