[GitHub] [carbondata] QiangCai commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent

Posted by GitBox on Feb 27, 2021; 8:33am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-QiangCai-opened-a-new-pull-request-4078-CARBONDATA-4075-Refactor-code-use-withEvent-tp105464p106478.html


QiangCai commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-787036665


   @VenuReddy2103
    I checked all places, but 14 places still keep the same with previous.
   1) in 9 places, it uses only one event, fireEvent is ok.
   2) in 4 places, preEvent and postEvent are in the different code blocks.
   3) in 1 place, there is a large code block between preEvent and postEvent.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]