[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

Posted by GitBox on Mar 08, 2021; 9:20am
URL: http://apache-carbondata-dev-mailing-list-archive.168.s1.nabble.com/GitHub-carbondata-ShreelekhyaG-opened-a-new-pull-request-4096-CARBONDATA-4133-Concurrent-Insert-Overs-tp106363p106562.html


ShreelekhyaG commented on a change in pull request #4096:
URL: https://github.com/apache/carbondata/pull/4096#discussion_r589273743



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlockletWrapper.java
##########
@@ -121,8 +121,9 @@ public ExtendedBlockletWrapper(List<ExtendedBlocklet> extendedBlockletList, Stri
     DataOutputStream stream = new DataOutputStream(bos);
     try {
       for (ExtendedBlocklet extendedBlocklet : extendedBlockletList) {
+        boolean isExternalPath = !extendedBlocklet.getFilePath().contains(tablePath);

Review comment:
       ok, removed. using isexternalSegment flag instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]